From e74e3e11415ff4e300b41d2766c5198fee293312 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Nicu=C8=99or=20C=C3=AE=C8=9Bu?= Date: Wed, 14 Apr 2021 16:15:02 +0300 Subject: [PATCH] MGS-6197 [#imx-2532] GPU crash when changing gpu_govern mode MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit No need to power on during suspend. 1. If the GPU core is already on, then no change performed. 2. If the GPU core is already in idle/suspend/power_off it means the Stall has already been done. No need to power it on again and put into idle state again. 3. If the GPU core is in idle and we want to put into suspend or power_off, that will be handled inside the gckHARDWARE_SetPowerState(). Signed-off-by: Nicușor Cîțu --- .../hal/os/linux/kernel/gc_hal_kernel_device.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/mxc/gpu-viv/hal/os/linux/kernel/gc_hal_kernel_device.c b/drivers/mxc/gpu-viv/hal/os/linux/kernel/gc_hal_kernel_device.c index ebbc31d393ce..2a39b0770965 100644 --- a/drivers/mxc/gpu-viv/hal/os/linux/kernel/gc_hal_kernel_device.c +++ b/drivers/mxc/gpu-viv/hal/os/linux/kernel/gc_hal_kernel_device.c @@ -3011,18 +3011,6 @@ gckGALDEVICE_Suspend( /* Store state. */ Device->statesStored[i] = currentState; - /* Pull up power to flush GPU command buffer before suspending. */ -#if gcdENABLE_VG - if (i == gcvCORE_VG) - { - gcmkONERROR(gckVGHARDWARE_SetPowerState(hardware, gcvPOWER_ON)); - } - else -#endif - { - gcmkONERROR(gckHARDWARE_SetPowerState(hardware, gcvPOWER_ON)); - } - #if gcdENABLE_VG if (i == gcvCORE_VG) { -- 2.17.1