From d05ef2173dac39443fc94d4b010c27d669fc1b03 Mon Sep 17 00:00:00 2001 From: Etienne Carriere Date: Thu, 24 Aug 2017 15:44:46 +0200 Subject: [PATCH] ion: fix unmapped heap test settings **not for mainline** If one enables ION_DUMMY_UNMAPPED_HEAP without providing the target unmapped heap configuration settings (physical base address and size), the kernel cannot build. This situation occurs in Linux test build cases, i.e running the allmodconfig configuration. This change overcomes the issue by providing default null settings for both ION_DUMMY_UNMAPPED_BASE and ION_DUMMY_UNMAPPED_SIZE. Signed-off-by: Etienne Carriere Acked-by: Jens Wiklander (cherry picked from commit ac0c2c26b9819c5e95d56cb2d8937de0357eecaa linaro repo https://github.com/linaro-swg/linux.git tag optee-v4.9-20171005) --- drivers/staging/android/ion/Kconfig | 2 ++ drivers/staging/android/ion/ion_dummy_driver.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig index 4c2631604be3..821871ddf678 100644 --- a/drivers/staging/android/ion/Kconfig +++ b/drivers/staging/android/ion/Kconfig @@ -71,6 +71,7 @@ config ION_DUMMY_UNMAPPED_HEAP config ION_DUMMY_UNMAPPED_BASE hex "Physical base address of the ION unmapped heap" depends on ION_DUMMY_UNMAPPED_HEAP + default 0 help Allows one the statically define an unmapped heap from the ION dummy driver to exercice unamped heaps buffer managment. @@ -78,6 +79,7 @@ config ION_DUMMY_UNMAPPED_BASE config ION_DUMMY_UNMAPPED_SIZE hex "Physical byte size of the ION unmapped heap" depends on ION_DUMMY_UNMAPPED_HEAP + default 0 help Allows one the statically define an unmapped heap from the ION dummy driver to exercice unamped heaps buffer managment. diff --git a/drivers/staging/android/ion/ion_dummy_driver.c b/drivers/staging/android/ion/ion_dummy_driver.c index c39009a2edd1..504c379ab036 100644 --- a/drivers/staging/android/ion/ion_dummy_driver.c +++ b/drivers/staging/android/ion/ion_dummy_driver.c @@ -56,7 +56,7 @@ static struct ion_platform_heap dummy_heaps[] = { .align = SZ_16K, .priv = (void *)(SZ_16K), }, -#ifdef CONFIG_ION_DUMMY_UNMAPPED_HEAP +#if defined(CONFIG_ION_DUMMY_UNMAPPED_HEAP) && CONFIG_ION_DUMMY_UNMAPPED_SIZE { .id = ION_HEAP_TYPE_UNMAPPED, .type = ION_HEAP_TYPE_UNMAPPED, -- 2.17.1