From cbaa676cbbc88a1a73add1abb37c30ecd633192a Mon Sep 17 00:00:00 2001 From: Robby Cai Date: Fri, 7 May 2021 17:50:01 +0800 Subject: [PATCH] LF-2859 media: mxc_capture: Fix Coverity Issue: 17678 Dereference before null check Fix issue for dereference before NULL check Signed-off-by: Robby Cai Reviewed-by: G.n. Zhou --- drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c b/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c index b9dae9bc0221..7256565144ea 100644 --- a/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c +++ b/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c @@ -133,7 +133,7 @@ static int csi_enc_setup(cam_data *cam) { ipu_channel_params_t params; int err = 0, sensor_protocol = 0; - ipu_channel_t chan = (cam->csi == 0) ? CSI_MEM0 : CSI_MEM1; + ipu_channel_t chan; #ifdef CONFIG_MXC_MIPI_CSI2 void *mipi_csi2_info; int ipu_id; @@ -145,6 +145,7 @@ static int csi_enc_setup(cam_data *cam) printk(KERN_ERR "cam private is NULL\n"); return -ENXIO; } + chan = (cam->csi == 0) ? CSI_MEM0 : CSI_MEM1; memset(¶ms, 0, sizeof(ipu_channel_params_t)); params.csi_mem.csi = cam->csi; -- 2.17.1