From a7f3b3145b61a84f753a6b3187b0f4dcbb5e4d2e Mon Sep 17 00:00:00 2001 From: Liu Ying Date: Tue, 1 Dec 2015 14:42:41 +0800 Subject: [PATCH] MLK-11932 video: fbdev: mxc: ldb: Do not touch fbi->modelist in ldb_init() We don't have to touch fbi->modelist in ldb_init(), because mxcfb_register() may initialize the list and add a video mode to the list for us. This patch fixes the following issue reported by Coverity: INIT_LIST_HEAD(&fbi->modelist); Uninitialized scalar variable (UNINIT) uninit_use_in_call: Using uninitialized value fb_vm. Field fb_vm.name is uninitialized when calling fb_add_videomode. fb_add_videomode(&fb_vm, &fbi->modelist); fb_videomode_to_var(&fbi->var, &fb_vm); Signed-off-by: Liu Ying --- drivers/video/fbdev/mxc/ldb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/video/fbdev/mxc/ldb.c b/drivers/video/fbdev/mxc/ldb.c index e5716cb4b2e3..1d6c9e08590c 100644 --- a/drivers/video/fbdev/mxc/ldb.c +++ b/drivers/video/fbdev/mxc/ldb.c @@ -323,9 +323,6 @@ static int ldb_init(struct mxc_dispdrv_handle *mddh, chan->fbi = fbi; fb_videomode_from_videomode(&chan->vm, &fb_vm); - - INIT_LIST_HEAD(&fbi->modelist); - fb_add_videomode(&fb_vm, &fbi->modelist); fb_videomode_to_var(&fbi->var, &fb_vm); setting->crtc = chan->crtc; -- 2.17.1