From 9a63654ec976f2712571acfbb898435ab0c3ad3c Mon Sep 17 00:00:00 2001 From: Ye Li Date: Thu, 27 May 2021 01:05:44 -0700 Subject: [PATCH] LFU-18 spi: fsl_lpspi: Fix dereference before null check Fix coverity Issue: 11026161 Dereference before null check The lpspi should not be dereferenced before null checking, moving getting its udevice after the checking Signed-off-by: Ye Li Reviewed-by: Peng Fan --- drivers/spi/fsl_lpspi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/spi/fsl_lpspi.c b/drivers/spi/fsl_lpspi.c index 9c67f1a56c..7870b2702a 100644 --- a/drivers/spi/fsl_lpspi.c +++ b/drivers/spi/fsl_lpspi.c @@ -300,13 +300,15 @@ static int fsl_lpspi_xfer_internal(struct fsl_lpspi_slave *lpspi, u32 blk_size; struct LPSPI_Type *regs; u8 watermark = 0; - struct udevice *dev = lpspi->dev; - struct dm_spi_slave_plat *slave_plat = dev_get_parent_plat(dev); + struct udevice *dev; + struct dm_spi_slave_plat *slave_plat; if (!lpspi) return -EINVAL; regs = (struct LPSPI_Type *)lpspi->base; + dev = lpspi->dev; + slave_plat = dev_get_parent_plat(dev); ret = fsl_lpspi_check_trans_len(n_bytes, lpspi->wordlen); if (ret) -- 2.17.1