From 779ed133e9da4c649d9586f6a88049cf884c081a Mon Sep 17 00:00:00 2001 From: Clark Wang Date: Mon, 31 May 2021 10:34:49 +0800 Subject: [PATCH] LF-1723: spi: lpspi: run transfer speed_hz sanity check Coverity reports Division or modulo by zero potential issue(CWE-369) about the provided transfer speed_hz. Run sanity check first to avoid this problem. Signed-off-by: Han Xu Signed-off-by: Clark Wang Reviewed-by: Jun Li Acked-by: Jason Liu --- drivers/spi/spi-fsl-lpspi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 6c716e4500ab..9216cc67c1bb 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -302,6 +302,12 @@ static int fsl_lpspi_set_bitrate(struct fsl_lpspi_data *fsl_lpspi) perclk_rate = clk_get_rate(fsl_lpspi->clk_per); + if (!config.speed_hz) { + dev_err(fsl_lpspi->dev, + "error: the transmission speed provided is 0!\n"); + return -EINVAL; + } + if (config.speed_hz > perclk_rate / 2) { dev_err(fsl_lpspi->dev, "per-clk should be at least two times of transfer speed"); -- 2.17.1