From 4e129c79fd7267af2be611bd0219b2530add800a Mon Sep 17 00:00:00 2001 From: Anson Huang Date: Wed, 9 Dec 2015 18:51:22 +0800 Subject: [PATCH] MLK-11985-1 ARM: imx: fix coverity scan issues 1. Add return value check to fix below warning: check_return: Calling of_property_read_u32 without checking return value. 2. Improve code to fix below warning: copy_paste_error: i in of_clk_get(dev->of_node, i) looks like a copy-paste error. Signed-off-by: Anson Huang --- arch/arm/mach-imx/gpc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c index 9040e7ebafe7..26392c22a9c5 100644 --- a/arch/arm/mach-imx/gpc.c +++ b/arch/arm/mach-imx/gpc.c @@ -760,12 +760,12 @@ static int imx_gpc_genpd_init(struct device *dev, struct regulator *pu_reg) ipg = of_clk_get(dev->of_node, pu_clks); /* Get disp domain clks */ - for (k = 0, i = pu_clks + ipg_clks; i < pu_clks + ipg_clks + disp_clks; - i++, k++) { + for (i = pu_clks + ipg_clks; i < pu_clks + ipg_clks + disp_clks; + i++) { clk = of_clk_get(dev->of_node, i); if (IS_ERR(clk)) break; - imx6s_display_domain.clk[k] = clk; + imx6s_display_domain.clk[k++] = clk; } imx6s_display_domain.num_clks = k; @@ -815,7 +815,9 @@ static int imx_gpc_probe(struct platform_device *pdev) return ret; } - of_property_read_u32(pdev->dev.of_node, "fsl,ldo-bypass", &bypass); + if (of_property_read_u32(pdev->dev.of_node, "fsl,ldo-bypass", &bypass)) + dev_warn(&pdev->dev, + "no fsl,ldo-bypass found!\n"); /* We only bypass pu since arm and soc has been set in u-boot */ if (pu_reg && bypass) regulator_allow_bypass(pu_reg, true); -- 2.17.1