From 27e01091778e0cdf13ba5016a4ecc30c1ddf1f1f Mon Sep 17 00:00:00 2001 From: Robby Cai Date: Fri, 7 May 2021 17:42:42 +0800 Subject: [PATCH] LF-2858 media: ipu: Fix Coverity Issue: 17676 Dereference before null check Fix issue for dereference before NULL check Signed-off-by: Robby Cai Reviewed-by: G.n. Zhou --- drivers/media/platform/mxc/capture/ipu_prp_enc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mxc/capture/ipu_prp_enc.c b/drivers/media/platform/mxc/capture/ipu_prp_enc.c index d1e1def371e5..c26ef944cb46 100644 --- a/drivers/media/platform/mxc/capture/ipu_prp_enc.c +++ b/drivers/media/platform/mxc/capture/ipu_prp_enc.c @@ -63,7 +63,7 @@ static int prp_enc_setup(cam_data *cam) { ipu_channel_params_t enc; int err = 0; - dma_addr_t dummy = cam->dummy_frame.buffer.m.offset; + dma_addr_t dummy; #ifdef CONFIG_MXC_MIPI_CSI2 void *mipi_csi2_info; int ipu_id; @@ -75,6 +75,8 @@ static int prp_enc_setup(cam_data *cam) printk(KERN_ERR "cam private is NULL\n"); return -ENXIO; } + dummy = cam->dummy_frame.buffer.m.offset; + memset(&enc, 0, sizeof(ipu_channel_params_t)); ipu_csi_get_window_size(cam->ipu, &enc.csi_prp_enc_mem.in_width, -- 2.17.1