From 2096b34164e75dd11d218faf1b3f6d932bb2e7a1 Mon Sep 17 00:00:00 2001 From: Zidan Wang Date: Tue, 1 Dec 2015 16:14:26 +0800 Subject: [PATCH] MLK-11933 mfd: mxc-hdmi-core: null check substream before using it null check substream before using it. Reported by coverity. Signed-off-by: Zidan Wang (cherry picked from commit fad2b9c1285a34eab0dec9f90edc06ec94e70a61) --- drivers/mfd/mxc-hdmi-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/mxc-hdmi-core.c b/drivers/mfd/mxc-hdmi-core.c index ca79e7e4325a..a67040661b4a 100644 --- a/drivers/mfd/mxc-hdmi-core.c +++ b/drivers/mfd/mxc-hdmi-core.c @@ -153,9 +153,12 @@ int mxc_hdmi_register_audio(struct snd_pcm_substream *substream) unsigned long flags, flags1; int ret = 0; + if (!substream) + return -EINVAL; + snd_pcm_stream_lock_irqsave(substream, flags); - if (substream && check_hdmi_state()) { + if (check_hdmi_state()) { spin_lock_irqsave(&hdmi_audio_lock, flags1); if (hdmi_audio_stream_playback) { pr_err("%s unconsist hdmi auido stream!\n", __func__); -- 2.17.1