From 15469c27096b4474ecf8e9761d29a7645333d4a9 Mon Sep 17 00:00:00 2001 From: Mihai Serban Date: Wed, 9 Aug 2017 16:54:45 +0300 Subject: [PATCH] MLK-16177: soc: imx: Fix resources release in pm-domains detach_dev function Because of a typo the resources allocated in imx8_attach_dev were not correctly released by imx8_detach_dev. Fixes: a0fb334819bb ("MLK16147-2 soc:imx Add support to save/restore clock rates") Signed-off-by: Mihai Serban Reviewed-by: Ranjani Vaidyanathan --- drivers/soc/imx/pm-domains.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soc/imx/pm-domains.c b/drivers/soc/imx/pm-domains.c index 5f94b476966f..90cd2df2610d 100644 --- a/drivers/soc/imx/pm-domains.c +++ b/drivers/soc/imx/pm-domains.c @@ -182,15 +182,15 @@ static int imx8_attach_dev(struct generic_pm_domain *genpd, struct device *dev) static void imx8_detach_dev(struct generic_pm_domain *genpd, struct device *dev) { struct imx8_pm_domain *pd; - struct imx8_pm_rsrc_clks *imx8_rsrc_clk; + struct imx8_pm_rsrc_clks *imx8_rsrc_clk, *tmp; pd = container_of(genpd, struct imx8_pm_domain, pd); /* Free all the clock entry nodes. */ - if (!list_empty(&pd->clks)) + if (list_empty(&pd->clks)) return; - list_for_each_entry(imx8_rsrc_clk, &pd->clks, node) { + list_for_each_entry_safe(imx8_rsrc_clk, tmp, &pd->clks, node) { list_del(&imx8_rsrc_clk->node); devm_kfree(dev, imx8_rsrc_clk); } -- 2.17.1