From: Geert Uytterhoeven Date: Wed, 7 Nov 2018 13:37:31 +0000 (+0100) Subject: serial: sh-sci: Improve type-safety calling sci_receive_chars() X-Git-Tag: rel_imx_5.10.35_2.0.0-somdevices.0~5632^2~87 X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=ed8c8e1ecca08eb172463816ab290157b9d6ca0b;p=linux.git serial: sh-sci: Improve type-safety calling sci_receive_chars() While ptr and port both point to the uart_port structure, the former is the untyped pointer cookie passed to interrupt handlers. Use the correctly typed port variable instead, to improve type-safety. Signed-off-by: Geert Uytterhoeven Reviewed-by: Ulrich Hecht Reviewed-by: Simon Horman Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index ff6ba6d86cd8..dd3931dfebdc 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -1693,7 +1693,7 @@ static irqreturn_t sci_rx_interrupt(int irq, void *ptr) * of whether the I_IXOFF is set, otherwise, how is the interrupt * to be disabled? */ - sci_receive_chars(ptr); + sci_receive_chars(port); return IRQ_HANDLED; } @@ -1749,7 +1749,7 @@ static irqreturn_t sci_er_interrupt(int irq, void *ptr) } else { sci_handle_fifo_overrun(port); if (!s->chan_rx) - sci_receive_chars(ptr); + sci_receive_chars(port); } sci_clear_SCxSR(port, SCxSR_ERROR_CLEAR(port));