From: Gustavo A. R. Silva Date: Mon, 11 Feb 2019 18:43:23 +0000 (-0600) Subject: iscsi_ibft: Fix missing break in switch statement X-Git-Tag: rel_imx_5.10.35_2.0.0-somdevices.0~4167^2~2 X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=df997abeebadaa4824271009e2d2b526a70a11cb;p=linux.git iscsi_ibft: Fix missing break in switch statement Add missing break statement in order to prevent the code from falling through to case ISCSI_BOOT_TGT_NAME, which is unnecessary. This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough. Fixes: b33a84a38477 ("ibft: convert iscsi_ibft module to iscsi boot lib") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva Signed-off-by: Konrad Rzeszutek Wilk --- diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index 6bc8e6640d71..c51462f5aa1e 100644 --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c @@ -542,6 +542,7 @@ static umode_t __init ibft_check_tgt_for(void *data, int type) case ISCSI_BOOT_TGT_NIC_ASSOC: case ISCSI_BOOT_TGT_CHAP_TYPE: rc = S_IRUGO; + break; case ISCSI_BOOT_TGT_NAME: if (tgt->tgt_name_len) rc = S_IRUGO;