From: Tariq Toukan <tariqt@mellanox.com>
Date: Thu, 15 Nov 2018 09:48:41 +0000 (+0200)
Subject: net/mlx5e: XDP, Warn upon polling an error CQE
X-Git-Tag: rel_imx_5.10.35_2.0.0-somdevices.0~5663^2~11^2~5
X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=db02a308cd724fd37416012c8077d3e0ea2bf386;p=linux.git

net/mlx5e: XDP, Warn upon polling an error CQE

Do not ignore the CQE opcode.
This helps expose issues and debug them.

Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
---

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c
index 4961b8fea111..407e285b0430 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c
@@ -197,6 +197,11 @@ bool mlx5e_poll_xdpsq_cq(struct mlx5e_cq *cq, struct mlx5e_rq *rq)
 
 		wqe_counter = be16_to_cpu(cqe->wqe_counter);
 
+		if (unlikely(get_cqe_opcode(cqe) != MLX5_CQE_REQ))
+			netdev_WARN_ONCE(sq->channel->netdev,
+					 "Bad OP in XDPSQ CQE: 0x%x\n",
+					 get_cqe_opcode(cqe));
+
 		do {
 			u16 ci = mlx5_wq_cyc_ctr2ix(&sq->wq, sqcc);
 			struct mlx5e_xdp_info *xdpi = &sq->db.xdpi[ci];