From: Aliaksei Karaliou <akaraliou.dev@gmail.com>
Date: Thu, 7 Dec 2017 07:25:52 +0000 (+0300)
Subject: drivers: lustre: ldlm: check result of register_shrinker()
X-Git-Tag: rel_imx_4.19.35_1.1.0~10789^2~368
X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=d85db086cf0c9d8581765ec787ca38e4ee6f3171;p=linux.git

drivers: lustre: ldlm: check result of register_shrinker()

ldlm_pools_init() does not check result of register_shrinker()
which was tagged __must_check recently, reported by sparse.

Signed-off-by: Aliaksei Karaliou <akaraliou.dev@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
index da65d00a7811..8563bd32befa 100644
--- a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
+++ b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
@@ -1086,8 +1086,12 @@ int ldlm_pools_init(void)
 	int rc;
 
 	rc = ldlm_pools_thread_start();
-	if (rc == 0)
-		register_shrinker(&ldlm_pools_cli_shrinker);
+	if (rc)
+		return rc;
+
+	rc = register_shrinker(&ldlm_pools_cli_shrinker);
+	if (rc)
+		ldlm_pools_thread_stop();
 
 	return rc;
 }