From: Robby Cai Date: Fri, 7 May 2021 10:11:51 +0000 (+0800) Subject: LF-2861 media: mx6s_capture: Fix Coverity Issue: 17695 Dereference before null check X-Git-Tag: rel_imx_5.10.35_2.0.0-somdevices.0~94 X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=cbad61d3fbc46bcb3cea826d808a0452d46f07fb;p=linux.git LF-2861 media: mx6s_capture: Fix Coverity Issue: 17695 Dereference before null check Fix dereference before NULL check issue Signed-off-by: Robby Cai Reviewed-by: G.n. Zhou --- diff --git a/drivers/media/platform/mxc/capture/mx6s_capture.c b/drivers/media/platform/mxc/capture/mx6s_capture.c index 1fe51c3aa5d2..433f2d124d2c 100644 --- a/drivers/media/platform/mxc/capture/mx6s_capture.c +++ b/drivers/media/platform/mxc/capture/mx6s_capture.c @@ -1711,13 +1711,13 @@ static int subdev_notifier_bound(struct v4l2_async_notifier *notifier, { struct mx6s_csi_dev *csi_dev = notifier_to_mx6s_dev(notifier); + if (subdev == NULL) + return -EINVAL; + /* Find platform data for this sensor subdev */ if (csi_dev->asd.match.fwnode == dev_fwnode(subdev->dev)) csi_dev->sd = subdev; - if (subdev == NULL) - return -EINVAL; - v4l2_info(&csi_dev->v4l2_dev, "Registered sensor subdevice: %s\n", subdev->name);