From: Robby Cai <robby.cai@nxp.com>
Date: Fri, 7 May 2021 09:50:01 +0000 (+0800)
Subject: LF-2859 media: mxc_capture: Fix Coverity Issue: 17678 Dereference before null check
X-Git-Tag: rel_imx_5.10.35_2.0.0-somdevices.0~96
X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=cbaa676cbbc88a1a73add1abb37c30ecd633192a;p=linux.git

LF-2859 media: mxc_capture: Fix Coverity Issue: 17678 Dereference before null check

Fix issue for dereference before NULL check

Signed-off-by: Robby Cai <robby.cai@nxp.com>
Reviewed-by: G.n. Zhou <guoniu.zhou@nxp.com>
---

diff --git a/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c b/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c
index b9dae9bc0221..7256565144ea 100644
--- a/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c
+++ b/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c
@@ -133,7 +133,7 @@ static int csi_enc_setup(cam_data *cam)
 {
 	ipu_channel_params_t params;
 	int err = 0, sensor_protocol = 0;
-	ipu_channel_t chan = (cam->csi == 0) ? CSI_MEM0 : CSI_MEM1;
+	ipu_channel_t chan;
 #ifdef CONFIG_MXC_MIPI_CSI2
 	void *mipi_csi2_info;
 	int ipu_id;
@@ -145,6 +145,7 @@ static int csi_enc_setup(cam_data *cam)
 		printk(KERN_ERR "cam private is NULL\n");
 		return -ENXIO;
 	}
+	chan = (cam->csi == 0) ? CSI_MEM0 : CSI_MEM1;
 
 	memset(&params, 0, sizeof(ipu_channel_params_t));
 	params.csi_mem.csi = cam->csi;