From: Tang Bin <tangbin@cmss.chinamobile.com>
Date: Fri, 8 May 2020 11:43:05 +0000 (+0800)
Subject: USB: EHCI: ehci-mv: fix error handling in mv_ehci_probe()
X-Git-Tag: rel_imx_5.10.35_2.0.0-somdevices.0~1997^2~45
X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=c856b4b0fdb5044bca4c0acf9a66f3b5cc01a37a;p=linux.git

USB: EHCI: ehci-mv: fix error handling in mv_ehci_probe()

If the function platform_get_irq() failed, the negative value
returned will not be detected here. So fix error handling in
mv_ehci_probe(). And when get irq failed, the function
platform_get_irq() logs an error message, so remove redundant
message here.

Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Link: https://lore.kernel.org/r/20200508114305.15740-1-tangbin@cmss.chinamobile.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
index 8f692fe17f45..0d61f43c29dc 100644
--- a/drivers/usb/host/ehci-mv.c
+++ b/drivers/usb/host/ehci-mv.c
@@ -167,9 +167,8 @@ static int mv_ehci_probe(struct platform_device *pdev)
 	hcd->regs = ehci_mv->op_regs;
 
 	hcd->irq = platform_get_irq(pdev, 0);
-	if (!hcd->irq) {
-		dev_err(&pdev->dev, "Cannot get irq.");
-		retval = -ENODEV;
+	if (hcd->irq < 0) {
+		retval = hcd->irq;
 		goto err_disable_clk;
 	}