From: Dan Carpenter Date: Wed, 29 Jan 2020 17:30:37 +0000 (+0300) Subject: USB: serial: ir-usb: Silence harmless uninitialized variable warning X-Git-Tag: rel_imx_5.10.35_2.0.0-somdevices.0~2772^2~4^2~1 X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=c664a4fa8f69308b8f624cff4fa1294e9aef880d;p=linux.git USB: serial: ir-usb: Silence harmless uninitialized variable warning The "actual_length" variable might be uninitialized on some failure paths. It's harmless but static analysis tools like Smatch complain and at runtime the UBSan tool will likely complain as well. Fixes: e7542bc382f8 ("USB: serial: ir-usb: make set_termios synchronous") Signed-off-by: Dan Carpenter Signed-off-by: Johan Hovold --- diff --git a/drivers/usb/serial/ir-usb.c b/drivers/usb/serial/ir-usb.c index 79d0586e2b33..172261a908d8 100644 --- a/drivers/usb/serial/ir-usb.c +++ b/drivers/usb/serial/ir-usb.c @@ -448,7 +448,7 @@ static void ir_set_termios(struct tty_struct *tty, usb_sndbulkpipe(udev, port->bulk_out_endpointAddress), transfer_buffer, 1, &actual_length, 5000); if (ret || actual_length != 1) { - if (actual_length != 1) + if (!ret) ret = -EIO; dev_err(&port->dev, "failed to change line speed: %d\n", ret); }