From: Christophe JAILLET Date: Wed, 17 Oct 2018 08:15:34 +0000 (+0200) Subject: staging: rtl8723bs: Fix the return value in case of error in 'rtw_wx_read32()' X-Git-Tag: rel_imx_5.10.35_2.0.0-somdevices.0~5840^2~9 X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=c3e43d8b958bd6849817393483e805d8638a8ab7;p=linux.git staging: rtl8723bs: Fix the return value in case of error in 'rtw_wx_read32()' We return 0 unconditionally in 'rtw_wx_read32()'. However, 'ret' is set to some error codes in several error handling paths. Return 'ret' instead to propagate the error code. Fixes: 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver") Signed-off-by: Christophe JAILLET Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index 28bfdbdc6e76..b8631baf128d 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -2289,7 +2289,7 @@ static int rtw_wx_read32(struct net_device *dev, exit: kfree(ptmp); - return 0; + return ret; } static int rtw_wx_write32(struct net_device *dev,