From: Jing Xiangfeng <jingxiangfeng@huawei.com>
Date: Tue, 17 Nov 2020 02:59:17 +0000 (+0800)
Subject: Bluetooth: btusb: Add the missed release_firmware() in btusb_mtk_setup_firmware()
X-Git-Tag: rel_imx_5.10.35_2.0.0-somdevices.0~491^2~382
X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=ae0e737765b88e48db69e485ebe9a70716ecad46;p=linux.git

Bluetooth: btusb: Add the missed release_firmware() in btusb_mtk_setup_firmware()

[ Upstream commit d1e9d232e1e60fa63df1b836ec3ecba5abd3fa9d ]

btusb_mtk_setup_firmware() misses to call release_firmware() in an error
path. Jump to err_release_fw to fix it.

Fixes: f645125711c8 ("Bluetooth: btusb: fix up firmware download sequence")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 1005b6e8ff74..a9981678199d 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -3067,7 +3067,7 @@ static int btusb_mtk_setup_firmware(struct hci_dev *hdev, const char *fwname)
 	err = btusb_mtk_hci_wmt_sync(hdev, &wmt_params);
 	if (err < 0) {
 		bt_dev_err(hdev, "Failed to power on data RAM (%d)", err);
-		return err;
+		goto err_release_fw;
 	}
 
 	fw_ptr = fw->data;