From: Colin Ian King <colin.king@canonical.com>
Date: Tue, 15 Aug 2017 07:38:45 +0000 (+0100)
Subject: usb: gadget: dummy: fix infinite loop because of missing loop decrement
X-Git-Tag: rel_imx_4.19.35_1.1.0~11814^2~31^2~30
X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=a79741fdb0605d75323872035d858556c8388e77;p=linux.git

usb: gadget: dummy: fix infinite loop because of missing loop decrement

The while loop never terminates because the loop counter i is never
decremented. Fix this by decrementing i.

Detected by CoverityScan, CID#751073 ("Infinite Loop")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
---

diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index 3c3760315910..a030d7923d7d 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -2776,7 +2776,7 @@ static int __init init(void)
 		if (retval < 0) {
 			i--;
 			while (i >= 0)
-				platform_device_del(the_udc_pdev[i]);
+				platform_device_del(the_udc_pdev[i--]);
 			goto err_add_udc;
 		}
 	}