From: Anson Huang Date: Tue, 7 Apr 2015 06:32:09 +0000 (+0800) Subject: MLK-10591-2 ARM: imx: add necessary delay for gpc power switch X-Git-Tag: C0P2-H0.0--20200415~4255 X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=a637b9372fc1bd76665f5a8f8a3ba2000423baa7;p=linux.git MLK-10591-2 ARM: imx: add necessary delay for gpc power switch Per design team's requirement, when GPC switch power req is assert and self-clear, need to add delay to make sure power switch is actually up, the delay value can be got from below: delay = 2us * 66MHz / IPG_RATE, here we add 2us margin to make it more reliable, currently only display mix and pu mix are a power switch. Signed-off-by: Anson Huang Signed-off-by: Robin Gong (cherry picked from commit 39601d70efcf49a91da01be7dff6e8c0d4b061ad) --- diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c index b8a420b86348..e20a8c1a2237 100644 --- a/arch/arm/mach-imx/gpc.c +++ b/arch/arm/mach-imx/gpc.c @@ -64,6 +64,8 @@ #define GPU_VPU_PDN_REQ BIT(0) #define GPC_CLK_MAX 10 +#define DEFAULT_IPG_RATE 66000000 +#define GPC_PU_UP_DELAY_MARGIN 2 struct pu_domain { struct generic_pm_domain base; @@ -89,6 +91,7 @@ static struct pu_domain imx6q_pu_domain; static bool pu_on; /* keep always on i.mx6qp */ static void _imx6q_pm_pu_power_off(struct generic_pm_domain *genpd); static void _imx6q_pm_pu_power_on(struct generic_pm_domain *genpd); +static struct clk *ipg; void imx_gpc_add_m4_wake_up_irq(u32 hwirq, bool enable) { @@ -630,6 +633,7 @@ static int imx_pm_dispmix_on(struct generic_pm_domain *genpd) struct disp_domain *disp = container_of(genpd, struct disp_domain, base); u32 val = readl_relaxed(gpc_base + GPC_CNTR); int i; + u32 ipg_rate = clk_get_rate(ipg); if ((cpu_is_imx6sl() && imx_get_soc_revision() >= IMX_CHIP_REVISION_1_2) || cpu_is_imx6sx()) { @@ -645,6 +649,10 @@ static int imx_pm_dispmix_on(struct generic_pm_domain *genpd) writel_relaxed(0x1, gpc_base + GPC_PGC_DISP_SR_OFFSET); + /* Wait power switch done */ + udelay(2 * DEFAULT_IPG_RATE / ipg_rate + + GPC_PU_UP_DELAY_MARGIN); + /* Disable reset clocks for all devices in the disp domain */ for (i = 0; i < disp->num_clks; i++) clk_disable_unprepare(disp->clk[i]); @@ -723,7 +731,7 @@ static int imx_gpc_genpd_init(struct device *dev, struct regulator *pu_reg) { struct clk *clk; bool is_off; - int pu_clks, disp_clks; + int pu_clks, disp_clks, ipg_clks = 1; int i = 0, k = 0, ret; imx6q_pu_domain.reg = pu_reg; @@ -731,12 +739,12 @@ static int imx_gpc_genpd_init(struct device *dev, struct regulator *pu_reg) if ((cpu_is_imx6sl() && imx_get_soc_revision() >= IMX_CHIP_REVISION_1_2)) { pu_clks = 2 ; - disp_clks = 6; + disp_clks = 5; } else if (cpu_is_imx6sx()) { pu_clks = 1; - disp_clks = 8; + disp_clks = 7; } else { - pu_clks = GPC_CLK_MAX; + pu_clks = 6; disp_clks = 0; } @@ -749,8 +757,11 @@ static int imx_gpc_genpd_init(struct device *dev, struct regulator *pu_reg) } imx6q_pu_domain.num_clks = i; + ipg = of_clk_get(dev->of_node, pu_clks); + /* Get disp domain clks */ - for (k = 0, i = pu_clks; i < pu_clks + disp_clks ; i++, k++) { + for (k = 0, i = pu_clks + ipg_clks; i < pu_clks + ipg_clks + disp_clks; + i++, k++) { clk = of_clk_get(dev->of_node, i); if (IS_ERR(clk)) break;