From: Sergio Paracuellos Date: Fri, 15 Feb 2019 12:10:40 +0000 (+0100) Subject: staging: mt7621-pci: reverse condition to check for enabled port X-Git-Tag: rel_imx_5.10.35_2.0.0-somdevices.0~5215^2~63 X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=8b20408a56629a0bd4b04d1a440457cde41503f9;p=linux.git staging: mt7621-pci: reverse condition to check for enabled port Each enabled port is being checked in 'mt7621_pcie_enable_ports" function calling 'mt7621_pcie_enable_port'. The return value for this function on success is zero, so the check is reversed. Fix it. Fixes: 802a2f7b2fe3: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function Signed-off-by: Sergio Paracuellos Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c index 8a682ce22508..379ae780c691 100644 --- a/drivers/staging/mt7621-pci/pci-mt7621.c +++ b/drivers/staging/mt7621-pci/pci-mt7621.c @@ -506,7 +506,7 @@ static void mt7621_pcie_enable_ports(struct mt7621_pcie *pcie) list_for_each_entry(port, &pcie->ports, list) { if (port->enabled) { - if (!mt7621_pcie_enable_port(port)) { + if (mt7621_pcie_enable_port(port)) { dev_err(dev, "de-assert port %d PERST_N\n", port->slot); continue;