From: Matthieu CASTET <matthieu.castet@parrot.com>
Date: Tue, 12 Dec 2017 10:10:44 +0000 (+0100)
Subject: led: core: Fix brightness setting when setting delay_off=0
X-Git-Tag: C0P2-H0.0--20200415~4982
X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=86b9fa2190907f4f550d9d6bf490c5f89ca33836;p=linux.git

led: core: Fix brightness setting when setting delay_off=0


[ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ]

With the current code, the following sequence won't work :
echo timer > trigger

echo 0 >  delay_off
* at this point we call
** led_delay_off_store
** led_blink_set
---

diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c
index 3bce44893021..d70d4a5273b8 100644
--- a/drivers/leds/led-core.c
+++ b/drivers/leds/led-core.c
@@ -186,7 +186,7 @@ void led_blink_set(struct led_classdev *led_cdev,
 		   unsigned long *delay_on,
 		   unsigned long *delay_off)
 {
-	del_timer_sync(&led_cdev->blink_timer);
+	led_stop_software_blink(led_cdev);
 
 	led_cdev->flags &= ~LED_BLINK_ONESHOT;
 	led_cdev->flags &= ~LED_BLINK_ONESHOT_STOP;