From: Dan Carpenter Date: Mon, 6 Nov 2017 11:43:41 +0000 (+0300) Subject: drm/amd/display: checking for NULL instead of IS_ERR() X-Git-Tag: rel_imx_4.19.35_1.1.0~11238^2~1^2~11 X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=74baea4275ee130c67400b33c532da8999b530af;p=linux.git drm/amd/display: checking for NULL instead of IS_ERR() backlight_device_register() never returns NULL, it returns error pointers on error so the check here is wrong. Acked-by: Christian König Signed-off-by: Dan Carpenter Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 33a15a1d818c..75f9383f5b9b 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -1296,7 +1296,7 @@ amdgpu_dm_register_backlight_device(struct amdgpu_display_manager *dm) &amdgpu_dm_backlight_ops, &props); - if (NULL == dm->backlight_dev) + if (IS_ERR(dm->backlight_dev)) DRM_ERROR("DM: Backlight registration failed!\n"); else DRM_DEBUG_DRIVER("DM: Registered Backlight device: %s\n", bl_name);