From: Lyude Paul Date: Thu, 5 Nov 2020 23:57:02 +0000 (-0500) Subject: drm/edid: Fix uninitialized variable in drm_cvt_modes() X-Git-Tag: rel_imx_5.10.35_2.0.0-somdevices.0~491^2~654 X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=5d43f95abf1cfe2aebf06eddcc6531b20afebff6;p=linux.git drm/edid: Fix uninitialized variable in drm_cvt_modes() [ Upstream commit 991fcb77f490390bcad89fa67d95763c58cdc04c ] Noticed this when trying to compile with -Wall on a kernel fork. We potentially don't set width here, which causes the compiler to complain about width potentially being uninitialized in drm_cvt_modes(). So, let's fix that. Changes since v1: * Don't emit an error as this code isn't reachable, just mark it as such Changes since v2: * Remove now unused variable Fixes: 3f649ab728cd ("treewide: Remove uninitialized_var() usage") Signed-off-by: Lyude Paul Reviewed-by: Ilia Mirkin Link: https://patchwork.freedesktop.org/patch/msgid/20201105235703.1328115-1-lyude@redhat.com Signed-off-by: Sasha Levin --- diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 631125b46e04..b84efd538a70 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3114,6 +3114,8 @@ static int drm_cvt_modes(struct drm_connector *connector, case 0x0c: width = height * 15 / 9; break; + default: + unreachable(); } for (j = 1; j < 5; j++) {