From: Kangjie Lu <kjlu@umn.edu>
Date: Wed, 26 Dec 2018 02:43:33 +0000 (-0600)
Subject: rtc: coh901331: fix a missing check of clk_prepare
X-Git-Tag: rel_imx_5.10.35_2.0.0-somdevices.0~5176^2~50
X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=5910fa0d0d9809c4d8fbf1fb905a8c86fbf2eccb;p=linux.git

rtc: coh901331: fix a missing check of clk_prepare

clk_prepare() could fail, so let's check its status and if it fails
return its error code upstream.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---

diff --git a/drivers/rtc/rtc-coh901331.c b/drivers/rtc/rtc-coh901331.c
index fc5cf5c44ae7..0b232c84f674 100644
--- a/drivers/rtc/rtc-coh901331.c
+++ b/drivers/rtc/rtc-coh901331.c
@@ -235,9 +235,13 @@ static int coh901331_suspend(struct device *dev)
 
 static int coh901331_resume(struct device *dev)
 {
+	int ret;
 	struct coh901331_port *rtap = dev_get_drvdata(dev);
 
-	clk_prepare(rtap->clk);
+	ret = clk_prepare(rtap->clk);
+	if (ret)
+		return ret;
+
 	if (device_may_wakeup(dev)) {
 		disable_irq_wake(rtap->irq);
 	} else {