From: Ernst Sjöstrand Date: Tue, 7 Nov 2017 20:18:06 +0000 (+0100) Subject: amdgpu/dc: Fix double unlock in amdgpu_dm_commit_planes X-Git-Tag: rel_imx_4.19.35_1.1.0~11238^2~1^2~3 X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=53a23207f2a17fd990c85bd84c45d243463e21bb;p=linux.git amdgpu/dc: Fix double unlock in amdgpu_dm_commit_planes Reported by smartch: amdgpu_dm_commit_planes() error: double unlock 'spin_lock:&crtc->dev->event_lock' amdgpu_dm_commit_planes() error: double unlock 'irqsave:flags' The error path doesn't return so we only need a single unlock. Reviewed-by: Harry Wentland Signed-off-by: Ernst Sjöstrand Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index cb45a3dc5a65..8ed6767b4616 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -3904,7 +3904,6 @@ static void amdgpu_dm_commit_planes(struct drm_atomic_state *state, DRM_ERROR("%s: acrtc %d, already busy\n", __func__, acrtc_attach->crtc_id); - spin_unlock_irqrestore(&crtc->dev->event_lock, flags); /* In commit tail framework this cannot happen */ WARN_ON(1); }