From: Robby Cai <robby.cai@nxp.com>
Date: Fri, 7 May 2021 09:24:51 +0000 (+0800)
Subject: LF-2488 media: mxc_capture: Fix Coverity Issue:11024996 Unchecked return value
X-Git-Tag: rel_imx_5.10.35_2.0.0-somdevices.0~101
X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=4e66a87f64f29ceced28061bbcd7eff76924db41;p=linux.git

LF-2488 media: mxc_capture: Fix Coverity Issue:11024996 Unchecked return value

Add return value check for fb_set_var

Signed-off-by: Robby Cai <robby.cai@nxp.com>
Reviewed-by: G.n. Zhou <guoniu.zhou@nxp.com>
---

diff --git a/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c b/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c
index 9e2a73032250..b9dae9bc0221 100644
--- a/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c
+++ b/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c
@@ -396,7 +396,9 @@ static int foreground_start(void *private)
 	fbvar.vmode &= ~FB_VMODE_YWRAP;
 	fbvar.accel_flags = FB_ACCEL_DOUBLE_FLAG;
 	fbvar.activate |= FB_ACTIVATE_FORCE;
-	fb_set_var(fbi, &fbvar);
+	err = fb_set_var(fbi, &fbvar);
+	if (err)
+		printk(KERN_WARNING "fb_set_var err code %d\n", err);
 
 	ipu_disp_set_window_pos(disp_ipu, MEM_FG_SYNC, cam->win.w.left,
 			cam->win.w.top);
@@ -489,7 +491,9 @@ static int foreground_stop(void *private)
 	fbvar.accel_flags = FB_ACCEL_TRIPLE_FLAG;
 	fbvar.nonstd = cam->fb_origin_std;
 	fbvar.activate |= FB_ACTIVATE_FORCE;
-	fb_set_var(fbi, &fbvar);
+	err = fb_set_var(fbi, &fbvar);
+	if (err)
+		printk(KERN_WARNING "fb_set_var err code %d\n", err);
 
 #ifdef CONFIG_MXC_MIPI_CSI2
 	mipi_csi2_info = mipi_csi2_get_info();
diff --git a/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc.c b/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc.c
index e573f315ce14..f15eea6824c8 100644
--- a/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc.c
+++ b/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc.c
@@ -127,7 +127,9 @@ static int prpvf_start(void *private)
 	fbvar.yoffset = 0;
 	fbvar.accel_flags = FB_ACCEL_DOUBLE_FLAG;
 	fbvar.activate |= FB_ACTIVATE_FORCE;
-	fb_set_var(fbi, &fbvar);
+	err = fb_set_var(fbi, &fbvar);
+	if (err)
+		printk(KERN_WARNING "fb_set_var err code %d\n", err);
 
 	ipu_disp_set_window_pos(disp_ipu, MEM_FG_SYNC, cam->win.w.left,
 			cam->win.w.top);
@@ -434,7 +436,9 @@ static int prpvf_stop(void *private)
 	fbvar.accel_flags = FB_ACCEL_TRIPLE_FLAG;
 	fbvar.nonstd = cam->fb_origin_std;
 	fbvar.activate |= FB_ACTIVATE_FORCE;
-	fb_set_var(fbi, &fbvar);
+	err = fb_set_var(fbi, &fbvar);
+	if (err)
+		printk(KERN_WARNING "fb_set_var err code %d\n", err);
 
 #ifdef CONFIG_MXC_MIPI_CSI2
 	mipi_csi2_info = mipi_csi2_get_info();