From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Date: Wed, 2 Sep 2020 06:54:01 +0000 (+0200)
Subject: media: vivid: fix error path
X-Git-Tag: rel_imx_5.10.35_2.0.0-somdevices.0~1054^2~291
X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=49a3d74b46cb9cc2266c334844b353f65b367732;p=linux.git

media: vivid: fix error path

If something fails after calling v4l2_device_register(),
it should call v4l2_device_put().

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

diff --git a/drivers/media/test-drivers/vivid/vivid-core.c b/drivers/media/test-drivers/vivid/vivid-core.c
index 54df7e0c13fc..48809991f037 100644
--- a/drivers/media/test-drivers/vivid/vivid-core.c
+++ b/drivers/media/test-drivers/vivid/vivid-core.c
@@ -1698,10 +1698,8 @@ static int vivid_create_instance(struct platform_device *pdev, int inst)
 				       &has_tuner, &has_modulator,
 				       &ccs_cap, &ccs_out,
 				       in_type_counter, out_type_counter);
-	if (ret) {
-		kfree(dev);
-		return ret;
-	}
+	if (ret)
+		goto free_dev;
 
 	vivid_set_capabilities(dev);