From: Arvind Yadav Date: Thu, 16 Nov 2017 04:27:29 +0000 (+0530) Subject: isdn: hisax: Fix pnp_irq's error checking for setup_teles3 X-Git-Tag: rel_imx_4.19.35_1.1.0~11225^2~13^2 X-Git-Url: https://git.somdevices.com/?a=commitdiff_plain;h=20525563b218471fac7254b577ef6743a697d70a;p=linux.git isdn: hisax: Fix pnp_irq's error checking for setup_teles3 The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav Signed-off-by: David S. Miller --- diff --git a/drivers/isdn/hisax/teles3.c b/drivers/isdn/hisax/teles3.c index 38fb2c1a3f0f..1eef693f04f0 100644 --- a/drivers/isdn/hisax/teles3.c +++ b/drivers/isdn/hisax/teles3.c @@ -306,7 +306,7 @@ int setup_teles3(struct IsdnCard *card) card->para[2] = pnp_port_start(pnp_d, 1); card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1] || !card->para[2]) { + if (card->para[0] == -1 || !card->para[1] || !card->para[2]) { printk(KERN_ERR "Teles PnP:some resources are missing %ld/%lx/%lx\n", card->para[0], card->para[1], card->para[2]); pnp_disable_dev(pnp_d);