thunderbolt: Fix to check the return value of kmemdup
authorAditya Pakki <pakki001@umn.edu>
Mon, 25 Mar 2019 21:25:22 +0000 (16:25 -0500)
committerMika Westerberg <mika.westerberg@linux.intel.com>
Thu, 28 Mar 2019 08:33:59 +0000 (11:33 +0300)
uuid in add_switch is allocted via kmemdup which can fail. The patch
logs the error and cleans up the allocated memory for switch.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/thunderbolt/icm.c

index e3fc920..8b7f913 100644 (file)
@@ -473,6 +473,11 @@ static void add_switch(struct tb_switch *parent_sw, u64 route,
                goto out;
 
        sw->uuid = kmemdup(uuid, sizeof(*uuid), GFP_KERNEL);
+       if (!sw->uuid) {
+               tb_sw_warn(sw, "cannot allocate memory for switch\n");
+               tb_switch_put(sw);
+               goto out;
+       }
        sw->connection_id = connection_id;
        sw->connection_key = connection_key;
        sw->link = link;