crypto: ccree - remove empty cc_sram_mgr_fini()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 11 Feb 2020 18:19:01 +0000 (19:19 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 22 Feb 2020 01:25:43 +0000 (09:25 +0800)
cc_sram_mgr_fini() doesn't do anything, so it can just be removed.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ccree/cc_driver.c
drivers/crypto/ccree/cc_sram_mgr.c
drivers/crypto/ccree/cc_sram_mgr.h

index 599936a..f8aba89 100644 (file)
@@ -478,13 +478,13 @@ static int init_cc_resources(struct platform_device *plat_dev)
                cc_sram_alloc(new_drvdata, MAX_MLLI_BUFF_SIZE);
        if (new_drvdata->mlli_sram_addr == NULL_SRAM_ADDR) {
                rc = -ENOMEM;
-               goto post_sram_mgr_err;
+               goto post_fips_init_err;
        }
 
        rc = cc_req_mgr_init(new_drvdata);
        if (rc) {
                dev_err(dev, "cc_req_mgr_init failed\n");
-               goto post_sram_mgr_err;
+               goto post_fips_init_err;
        }
 
        rc = cc_buffer_mgr_init(new_drvdata);
@@ -538,8 +538,6 @@ post_buf_mgr_err:
         cc_buffer_mgr_fini(new_drvdata);
 post_req_mgr_err:
        cc_req_mgr_fini(new_drvdata);
-post_sram_mgr_err:
-       cc_sram_mgr_fini(new_drvdata);
 post_fips_init_err:
        cc_fips_fini(new_drvdata);
 post_debugfs_err:
@@ -568,7 +566,6 @@ static void cleanup_cc_resources(struct platform_device *plat_dev)
        cc_pm_fini(drvdata);
        cc_buffer_mgr_fini(drvdata);
        cc_req_mgr_fini(drvdata);
-       cc_sram_mgr_fini(drvdata);
        cc_fips_fini(drvdata);
        cc_debugfs_fini(drvdata);
        fini_cc_regs(drvdata);
index 62c885e..a3c13b3 100644 (file)
@@ -12,16 +12,6 @@ struct cc_sram_ctx {
        cc_sram_addr_t sram_free_offset;
 };
 
-/**
- * cc_sram_mgr_fini() - Cleanup SRAM pool.
- *
- * @drvdata: Associated device driver context
- */
-void cc_sram_mgr_fini(struct cc_drvdata *drvdata)
-{
-       /* Nothing needed */
-}
-
 /**
  * cc_sram_mgr_init() - Initializes SRAM pool.
  *      The pool starts right at the beginning of SRAM.
index 1d14de9..971029b 100644 (file)
@@ -29,13 +29,6 @@ typedef u64 cc_sram_addr_t;
  */
 int cc_sram_mgr_init(struct cc_drvdata *drvdata);
 
-/*!
- * Uninits SRAM pool.
- *
- * \param drvdata
- */
-void cc_sram_mgr_fini(struct cc_drvdata *drvdata);
-
 /*!
  * Allocated buffer from SRAM pool.
  * Note: Caller is responsible to free the LAST allocated buffer.