crypto: caam - no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: "Horia Geantă" <horia.geanta@nxp.com>
Cc: Aymen Sghaier <aymen.sghaier@nxp.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index 14fb092..858bdc9 100644 (file)
--- a/drivers/crypto/caam/ctrl.c
+++ b/drivers/crypto/caam/ctrl.c
@@ -859,27 +859,18 @@ static int caam_probe(struct platform_device *pdev)
        /* Internal covering keys (useful in non-secure mode only) */
        ctrlpriv->ctl_kek_wrap.data = (__force void *)&ctrlpriv->ctrl->kek[0];
        ctrlpriv->ctl_kek_wrap.size = KEK_KEY_SIZE * sizeof(u32);
-       ctrlpriv->ctl_kek = debugfs_create_blob("kek",
-                                               S_IRUSR |
-                                               S_IRGRP | S_IROTH,
-                                               ctrlpriv->ctl,
-                                               &ctrlpriv->ctl_kek_wrap);
+       debugfs_create_blob("kek", S_IRUSR | S_IRGRP | S_IROTH, ctrlpriv->ctl,
+                           &ctrlpriv->ctl_kek_wrap);
 
        ctrlpriv->ctl_tkek_wrap.data = (__force void *)&ctrlpriv->ctrl->tkek[0];
        ctrlpriv->ctl_tkek_wrap.size = KEK_KEY_SIZE * sizeof(u32);
-       ctrlpriv->ctl_tkek = debugfs_create_blob("tkek",
-                                                S_IRUSR |
-                                                S_IRGRP | S_IROTH,
-                                                ctrlpriv->ctl,
-                                                &ctrlpriv->ctl_tkek_wrap);
+       debugfs_create_blob("tkek", S_IRUSR | S_IRGRP | S_IROTH, ctrlpriv->ctl,
+                           &ctrlpriv->ctl_tkek_wrap);
 
        ctrlpriv->ctl_tdsk_wrap.data = (__force void *)&ctrlpriv->ctrl->tdsk[0];
        ctrlpriv->ctl_tdsk_wrap.size = KEK_KEY_SIZE * sizeof(u32);
-       ctrlpriv->ctl_tdsk = debugfs_create_blob("tdsk",
-                                                S_IRUSR |
-                                                S_IRGRP | S_IROTH,
-                                                ctrlpriv->ctl,
-                                                &ctrlpriv->ctl_tdsk_wrap);
+       debugfs_create_blob("tdsk", S_IRUSR | S_IRGRP | S_IROTH, ctrlpriv->ctl,
+                           &ctrlpriv->ctl_tdsk_wrap);
 #endif
        return 0;
 

diff --git a/drivers/crypto/caam/intern.h b/drivers/crypto/caam/intern.h
index babc78a..5869ad5 100644 (file)
--- a/drivers/crypto/caam/intern.h
+++ b/drivers/crypto/caam/intern.h
@@ -106,7 +106,6 @@ struct caam_drv_private {
        struct dentry *dfs_root;
        struct dentry *ctl; /* controller dir */
        struct debugfs_blob_wrapper ctl_kek_wrap, ctl_tkek_wrap, ctl_tdsk_wrap;
-       struct dentry *ctl_kek, *ctl_tkek, *ctl_tdsk;
 #endif
 };