f2fs: flush data when enabling checkpoint back
authorJaegeuk Kim <jaegeuk@kernel.org>
Wed, 27 Jan 2021 01:00:42 +0000 (17:00 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Mar 2021 10:38:43 +0000 (11:38 +0100)
commit b0ff4fe746fd028eef920ddc8c7b0361c1ede6ec upstream.

During checkpoint=disable period, f2fs bypasses all the synchronous IOs such as
sync and fsync. So, when enabling it back, we must flush all of them in order
to keep the data persistent. Otherwise, suddern power-cut right after enabling
checkpoint will cause data loss.

Fixes: 4354994f097d ("f2fs: checkpoint disabling")
Cc: stable@vger.kernel.org
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/f2fs/super.c

index aa284ce..4fffbef 100644 (file)
@@ -1764,6 +1764,9 @@ restore_flag:
 
 static void f2fs_enable_checkpoint(struct f2fs_sb_info *sbi)
 {
+       /* we should flush all the data to keep data consistency */
+       sync_inodes_sb(sbi->sb);
+
        down_write(&sbi->gc_lock);
        f2fs_dirty_to_prefree(sbi);