MLK-20207-1: input: synaptics_dsx_i2c: fix coverity wrong sizeof argument issue
authorHaibo Chen <haibo.chen@nxp.com>
Mon, 19 Nov 2018 09:26:03 +0000 (17:26 +0800)
committerLeonard Crestez <leonard.crestez@nxp.com>
Wed, 17 Apr 2019 23:51:34 +0000 (02:51 +0300)
CID 3869704: Wrong sizeof argument (SIZEOF_MISMATCH)
suspicious_sizeof: Passing argument f1a->button_control.txrx_map of
type unsigned char * and argument 8 /* sizeof (f1a->button_control.txrx_map) */
to function synaptics_rmi4_i2c_read is suspicious.

Passing argument should be sizeof(unsigned char) rather than
sizeof(unsigned char *).

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
(cherry picked from commit 4583a0bc1ff6684e1d850eb50308ad8ae2fea627)
Signed-off-by: Arulpandiyan Vadivel <arulpandiyan_vadivel@mentor.com>
drivers/input/touchscreen/synaptics_dsx/synaptics_dsx_i2c.c

index 1ecf79c..64089d3 100644 (file)
@@ -2229,7 +2229,7 @@ static int synaptics_rmi4_f1a_button_map(struct synaptics_rmi4_data *rmi4_data,
                retval = synaptics_rmi4_i2c_read(rmi4_data,
                                fhandler->full_addr.ctrl_base + mapping_offset,
                                f1a->button_control.txrx_map,
-                               sizeof(f1a->button_control.txrx_map));
+                               sizeof(*(f1a->button_control.txrx_map)));
                if (retval < 0) {
                        dev_err(&rmi4_data->i2c_client->dev,
                                        "%s: Failed to read tx rx mapping\n",