ath10k: Revert "ath10k: add cleanup in ath10k_sta_state()"
authorBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 13 Nov 2019 20:26:44 +0000 (12:26 -0800)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 15 Nov 2019 06:56:38 +0000 (08:56 +0200)
This reverts commit 334f5b61a6f29834e881923b98d1e27e5ce9620d.

This caused ath10k_snoc on Qualcomm MSM8998, SDM845 and QCS404 platforms to
trigger an assert in the firmware:

err_qdi.c:456:EF:wlan_process:1:cmnos_thread.c:3900:Asserted in wlan_vdev.c:_wlan_vdev_up:3219

Revert the offending commit for now.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath10k/mac.c

index 5e3450c..83cc877 100644 (file)
@@ -6639,12 +6639,8 @@ static int ath10k_sta_state(struct ieee80211_hw *hw,
 
                spin_unlock_bh(&ar->data_lock);
 
-               if (!sta->tdls) {
-                       ath10k_peer_delete(ar, arvif->vdev_id, sta->addr);
-                       ath10k_mac_dec_num_stations(arvif, sta);
-                       kfree(arsta->tx_stats);
+               if (!sta->tdls)
                        goto exit;
-               }
 
                ret = ath10k_wmi_update_fw_tdls_state(ar, arvif->vdev_id,
                                                      WMI_TDLS_ENABLE_ACTIVE);