projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
75e9a33
)
mtd: rawnand: tmio: Stop using nand_release()
author
Miquel Raynal
<miquel.raynal@bootlin.com>
Tue, 19 May 2020 13:00:30 +0000
(15:00 +0200)
committer
Miquel Raynal
<miquel.raynal@bootlin.com>
Sun, 31 May 2020 08:53:36 +0000
(10:53 +0200)
This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().
Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link:
https://lore.kernel.org/linux-mtd/20200519130035.1883-58-miquel.raynal@bootlin.com
drivers/mtd/nand/raw/tmio_nand.c
patch
|
blob
|
history
diff --git
a/drivers/mtd/nand/raw/tmio_nand.c
b/drivers/mtd/nand/raw/tmio_nand.c
index
4e9a6d9
..
843a868
100644
(file)
--- a/
drivers/mtd/nand/raw/tmio_nand.c
+++ b/
drivers/mtd/nand/raw/tmio_nand.c
@@
-458,8
+458,12
@@
err_irq:
static int tmio_remove(struct platform_device *dev)
{
struct tmio_nand *tmio = platform_get_drvdata(dev);
+ struct nand_chip *chip = &tmio->chip;
+ int ret;
- nand_release(&tmio->chip);
+ ret = mtd_device_unregister(nand_to_mtd(chip));
+ WARN_ON(ret);
+ nand_cleanup(chip);
tmio_hw_stop(dev, tmio);
return 0;
}