RDMA/hns: Remove redundant parameters from free_srq/qp_wrid()
authorWenpeng Liang <liangwenpeng@huawei.com>
Fri, 22 May 2020 13:02:57 +0000 (21:02 +0800)
committerJason Gunthorpe <jgg@mellanox.com>
Mon, 25 May 2020 17:20:45 +0000 (14:20 -0300)
The redundant parameters "hr_dev" need to be removed from
free_kernel_wrid() and free_srq_wrid().

Link: https://lore.kernel.org/r/1590152579-32364-3-git-send-email-liweihang@huawei.com
Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
Signed-off-by: Weihang Li <liweihang@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hns/hns_roce_qp.c
drivers/infiniband/hw/hns/hns_roce_srq.c

index 5d29420..a0a47bd 100644 (file)
@@ -842,8 +842,7 @@ err_sq:
        return ret;
 }
 
-static void free_kernel_wrid(struct hns_roce_dev *hr_dev,
-                            struct hns_roce_qp *hr_qp)
+static void free_kernel_wrid(struct hns_roce_qp *hr_qp)
 {
        kfree(hr_qp->rq.wrid);
        kfree(hr_qp->sq.wrid);
@@ -996,7 +995,7 @@ err_buf:
 err_db:
        free_qp_db(hr_dev, hr_qp, udata);
 err_wrid:
-       free_kernel_wrid(hr_dev, hr_qp);
+       free_kernel_wrid(hr_qp);
        return ret;
 }
 
@@ -1010,7 +1009,7 @@ void hns_roce_qp_destroy(struct hns_roce_dev *hr_dev, struct hns_roce_qp *hr_qp,
        free_qpc(hr_dev, hr_qp);
        free_qpn(hr_dev, hr_qp);
        free_qp_buf(hr_dev, hr_qp);
-       free_kernel_wrid(hr_dev, hr_qp);
+       free_kernel_wrid(hr_qp);
        free_qp_db(hr_dev, hr_qp, udata);
 
        kfree(hr_qp);
index 3018c98..f40a000 100644 (file)
@@ -270,7 +270,7 @@ static int alloc_srq_wrid(struct hns_roce_dev *hr_dev, struct hns_roce_srq *srq)
        return 0;
 }
 
-static void free_srq_wrid(struct hns_roce_dev *hr_dev, struct hns_roce_srq *srq)
+static void free_srq_wrid(struct hns_roce_srq *srq)
 {
        kfree(srq->wrid);
        srq->wrid = NULL;
@@ -355,7 +355,7 @@ int hns_roce_create_srq(struct ib_srq *ib_srq,
 err_srqc_alloc:
        free_srqc(hr_dev, srq);
 err_wrid_alloc:
-       free_srq_wrid(hr_dev, srq);
+       free_srq_wrid(srq);
 err_idx_alloc:
        free_srq_idx(hr_dev, srq);
 err_buf_alloc:
@@ -370,7 +370,7 @@ void hns_roce_destroy_srq(struct ib_srq *ibsrq, struct ib_udata *udata)
 
        free_srqc(hr_dev, srq);
        free_srq_idx(hr_dev, srq);
-       free_srq_wrid(hr_dev, srq);
+       free_srq_wrid(srq);
        free_srq_buf(hr_dev, srq);
 }