projects
/
u-boot.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
86645c8
)
x86: gpio: Correct calls to _ich6_gpio_set_direction()
author
Simon Glass
<sjg@chromium.org>
Sat, 22 Aug 2015 21:58:58 +0000
(15:58 -0600)
committer
Simon Glass
<sjg@chromium.org>
Wed, 26 Aug 2015 14:54:15 +0000
(07:54 -0700)
These calls seem to be incorrect. The function expects an I/O address but
the existing callers pass the value at an I/O address. Fix it.
Signed-off-by: Simon Glass <sjg@chromium.org>
drivers/gpio/intel_ich6_gpio.c
patch
|
blob
|
history
diff --git
a/drivers/gpio/intel_ich6_gpio.c
b/drivers/gpio/intel_ich6_gpio.c
index
cb408a4
..
fd1f287
100644
(file)
--- a/
drivers/gpio/intel_ich6_gpio.c
+++ b/
drivers/gpio/intel_ich6_gpio.c
@@
-410,7
+410,7
@@
static int ich6_gpio_direction_input(struct udevice *dev, unsigned offset)
{
struct ich6_bank_priv *bank = dev_get_priv(dev);
- return _ich6_gpio_set_direction(
inl(bank->io_sel)
, offset, 0);
+ return _ich6_gpio_set_direction(
bank->io_sel
, offset, 0);
}
static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset,
@@
-419,7
+419,7
@@
static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset,
int ret;
struct ich6_bank_priv *bank = dev_get_priv(dev);
- ret = _ich6_gpio_set_direction(
inl(bank->io_sel)
, offset, 1);
+ ret = _ich6_gpio_set_direction(
bank->io_sel
, offset, 1);
if (ret)
return ret;