projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6cf238d
)
memory: fsl-corenet-cf: Fix handling of platform_get_irq() error
author
Krzysztof Kozlowski
<krzk@kernel.org>
Thu, 27 Aug 2020 07:33:15 +0000
(09:33 +0200)
committer
Krzysztof Kozlowski
<krzk@kernel.org>
Wed, 2 Sep 2020 15:32:02 +0000
(17:32 +0200)
platform_get_irq() returns -ERRNO on error. In such case comparison
to 0 would pass the check.
Fixes:
54afbec0d57f
("memory: Freescale CoreNet Coherency Fabric error reporting driver")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link:
https://lore.kernel.org/r/20200827073315.29351-1-krzk@kernel.org
drivers/memory/fsl-corenet-cf.c
patch
|
blob
|
history
diff --git
a/drivers/memory/fsl-corenet-cf.c
b/drivers/memory/fsl-corenet-cf.c
index
0b0ed72
..
0309bd5
100644
(file)
--- a/
drivers/memory/fsl-corenet-cf.c
+++ b/
drivers/memory/fsl-corenet-cf.c
@@
-211,10
+211,8
@@
static int ccf_probe(struct platform_device *pdev)
dev_set_drvdata(&pdev->dev, ccf);
irq = platform_get_irq(pdev, 0);
- if (!irq) {
- dev_err(&pdev->dev, "%s: no irq\n", __func__);
- return -ENXIO;
- }
+ if (irq < 0)
+ return irq;
ret = devm_request_irq(&pdev->dev, irq, ccf_irq, 0, pdev->name, ccf);
if (ret) {