MLK-11896-2 usb: chipidea: imx: derefence pointer after NULL check
authorLi Jun <jun.li@freescale.com>
Thu, 26 Nov 2015 09:34:18 +0000 (17:34 +0800)
committerNitin Garg <nitin.garg@nxp.com>
Mon, 19 Mar 2018 19:49:15 +0000 (14:49 -0500)
Dereference data pointer after its NULL check.

Signed-off-by: Li Jun <jun.li@freescale.com>
drivers/usb/chipidea/usbmisc_imx.c

index 1b55960..6e23a32 100644 (file)
@@ -991,12 +991,13 @@ EXPORT_SYMBOL_GPL(imx_usbmisc_set_wakeup);
 int imx_usbmisc_charger_detection(struct imx_usbmisc_data *data, bool connect)
 {
        struct imx_usbmisc *usbmisc;
-       struct usb_charger *charger = data->charger;
+       struct usb_charger *charger;
        int ret = 0;
 
        if (!data)
                return -EINVAL;
 
+       charger = data->charger;
        usbmisc = dev_get_drvdata(data->dev);
        if (!usbmisc->ops->charger_primary_detection)
                return -ENOTSUPP;