mfd: aat2870: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Jul 2019 16:47:22 +0000 (18:47 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Aug 2019 06:06:59 +0000 (08:06 +0200)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20190706164722.18766-3-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mfd/aat2870-core.c
include/linux/mfd/aat2870.h

index 9f58cb2..78ee4b2 100644 (file)
@@ -321,18 +321,9 @@ static const struct file_operations aat2870_reg_fops = {
 static void aat2870_init_debugfs(struct aat2870_data *aat2870)
 {
        aat2870->dentry_root = debugfs_create_dir("aat2870", NULL);
-       if (!aat2870->dentry_root) {
-               dev_warn(aat2870->dev,
-                        "Failed to create debugfs root directory\n");
-               return;
-       }
 
-       aat2870->dentry_reg = debugfs_create_file("regs", 0644,
-                                                 aat2870->dentry_root,
-                                                 aat2870, &aat2870_reg_fops);
-       if (!aat2870->dentry_reg)
-               dev_warn(aat2870->dev,
-                        "Failed to create debugfs register file\n");
+       debugfs_create_file("regs", 0644, aat2870->dentry_root, aat2870,
+                           &aat2870_reg_fops);
 }
 
 #else
index af7267c..2445842 100644 (file)
@@ -136,7 +136,6 @@ struct aat2870_data {
 
        /* for debugfs */
        struct dentry *dentry_root;
-       struct dentry *dentry_reg;
 };
 
 struct aat2870_subdev_info {