media: rc: ensure close() is called on rc_unregister_device
authorSean Young <sean@mess.org>
Sun, 4 Nov 2018 10:12:09 +0000 (05:12 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Feb 2019 18:47:01 +0000 (19:47 +0100)
[ Upstream commit 8e782fcf78275f505194e767c515202d4fd274bc ]

If userspace has an open file descriptor on the rc input device or lirc
device when rc_unregister_device() is called, then the rc close() is
never called.

This ensures that the receiver is turned off on the nuvoton-cir driver
during shutdown.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/rc/rc-main.c

index 8b2c16d..0f218af 100644 (file)
@@ -1956,6 +1956,8 @@ void rc_unregister_device(struct rc_dev *dev)
        rc_free_rx_device(dev);
 
        mutex_lock(&dev->lock);
+       if (dev->users && dev->close)
+               dev->close(dev);
        dev->registered = false;
        mutex_unlock(&dev->lock);