MLK-17274: drm: imx: dcss: use_global_alpha not working if channel
authorLaurentiu Palcu <laurentiu.palcu@nxp.com>
Wed, 20 Dec 2017 13:13:33 +0000 (15:13 +0200)
committerLeonard Crestez <leonard.crestez@nxp.com>
Wed, 17 Apr 2019 23:51:34 +0000 (02:51 +0300)
already enabled

If the channel is already enabled, or it doesn't need a mode set, then
the dcss_dtg_global_alpha_changed() will always return false for formats
with per-pixel alpha. Hence, the plane will not be updated. This patch
removes the check for image format and the check will be done for all
image formats.

Signed-off-by: Laurentiu Palcu <laurentiu.palcu@nxp.com>
drivers/gpu/imx/dcss/dcss-dtg.c

index f8f7b0e..1c2ad8f 100644 (file)
@@ -310,8 +310,7 @@ bool dcss_dtg_global_alpha_changed(struct dcss_soc *dcss, int ch_num,
        if (ch_num)
                return false;
 
-       return dcss_dtg_global_alpha_needed(pix_format) &&
-              (alpha != dtg->alpha || use_global_alpha != dtg->use_global);
+       return alpha != dtg->alpha || use_global_alpha != dtg->use_global;
 }
 EXPORT_SYMBOL(dcss_dtg_global_alpha_changed);