gpio: xgene-sb: Drop extra check to call acpi_gpiochip_request_interrupts()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 12 May 2020 18:27:21 +0000 (21:27 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 18 May 2020 07:16:31 +0000 (09:16 +0200)
There is no need to have an additional check to call
acpi_gpiochip_request_interrupts(). Even without any interrupts available
the registered ACPI Event handlers can be useful for debugging purposes.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200512182721.55127-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-xgene-sb.c

index 203a268..a809609 100644 (file)
@@ -290,10 +290,8 @@ static int xgene_gpio_sb_probe(struct platform_device *pdev)
 
        dev_info(&pdev->dev, "X-Gene GPIO Standby driver registered\n");
 
-       if (priv->nirq > 0) {
-               /* Register interrupt handlers for gpio signaled acpi events */
-               acpi_gpiochip_request_interrupts(&priv->gc);
-       }
+       /* Register interrupt handlers for GPIO signaled ACPI Events */
+       acpi_gpiochip_request_interrupts(&priv->gc);
 
        return ret;
 }
@@ -302,9 +300,7 @@ static int xgene_gpio_sb_remove(struct platform_device *pdev)
 {
        struct xgene_gpio_sb *priv = platform_get_drvdata(pdev);
 
-       if (priv->nirq > 0) {
-               acpi_gpiochip_free_interrupts(&priv->gc);
-       }
+       acpi_gpiochip_free_interrupts(&priv->gc);
 
        irq_domain_remove(priv->irq_domain);