media: marvell-ccic: power up the device on mclk enable
authorLubomir Rintel <lkundrak@v3.sk>
Wed, 27 Jan 2021 18:01:43 +0000 (19:01 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Mar 2021 10:38:34 +0000 (11:38 +0100)
commit 655ae29da72a693cf294bba3c3322e662ff75bd3 upstream.

Writing to REG_CLKCTRL with the power off causes a hang. Enable the
device first.

Cc: stable@vger.kernel.org # 5.10+
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/platform/marvell-ccic/mcam-core.c

index c012fd2..34266fb 100644 (file)
@@ -931,6 +931,7 @@ static int mclk_enable(struct clk_hw *hw)
                mclk_div = 2;
        }
 
+       pm_runtime_get_sync(cam->dev);
        clk_enable(cam->clk[0]);
        mcam_reg_write(cam, REG_CLKCTRL, (mclk_src << 29) | mclk_div);
        mcam_ctlr_power_up(cam);
@@ -944,6 +945,7 @@ static void mclk_disable(struct clk_hw *hw)
 
        mcam_ctlr_power_down(cam);
        clk_disable(cam->clk[0]);
+       pm_runtime_put(cam->dev);
 }
 
 static unsigned long mclk_recalc_rate(struct clk_hw *hw,