MLK-20190-03 brcmfmac: check thre return value of .brcmf_fil_iovar_data_get()
authorAndy Duan <fugang.duan@nxp.com>
Wed, 7 Nov 2018 07:06:03 +0000 (15:06 +0800)
committerLeonard Crestez <leonard.crestez@nxp.com>
Wed, 17 Apr 2019 23:51:34 +0000 (02:51 +0300)
Check the return value of .brcmf_fil_iovar_data_get() to fix
the coverity issue of "error handling issue".

Reviewed-by: Haibo Chen <haibo.chen@nxp.com>
Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: Arulpandiyan Vadivel <arulpandiyan_vadivel@mentor.com>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c

index be1acfa..eaca7e5 100644 (file)
@@ -2547,12 +2547,15 @@ brcmf_sdio_ulp_preinit(struct device *dev)
        struct brcmf_bus *bus_if = dev_get_drvdata(dev);
        struct brcmf_sdio_dev *sdiodev = bus_if->bus_priv.sdio;
        struct brcmf_if *ifp = bus_if->drvr->iflist[0];
+       s32 err = 0;
 
        brcmf_dbg(TRACE, "Enter\n");
 
        /* Query ulp_sdioctrl iovar to get the ULP related SHM offsets */
-       brcmf_fil_iovar_data_get(ifp, "ulp_sdioctrl", &sdiodev->shm_ulp,
-                                sizeof(sdiodev->shm_ulp));
+       err = brcmf_fil_iovar_data_get(ifp, "ulp_sdioctrl", &sdiodev->shm_ulp,
+                                      sizeof(sdiodev->shm_ulp));
+       if (err)
+               brcmf_err("ulp_sdioctrl iovar returned err = %d\n", err);
 
        sdiodev->ulp = false;