projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
67c3e59
)
powerpc/icp-hv: Fix missing of_node_put() in success path
author
Nicholas Mc Guire
<hofrat@osadl.org>
Wed, 4 Jul 2018 08:03:27 +0000
(10:03 +0200)
committer
Michael Ellerman
<mpe@ellerman.id.au>
Mon, 24 Aug 2020 15:31:31 +0000
(
01:31
+1000)
Both of_find_compatible_node() and of_find_node_by_type() will return
a refcounted node on success - thus for the success path the node must
be explicitly released with a of_node_put().
Fixes:
0b05ac6e2480
("powerpc/xics: Rewrite XICS driver")
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link:
https://lore.kernel.org/r/1530691407-3991-1-git-send-email-hofrat@osadl.org
arch/powerpc/sysdev/xics/icp-hv.c
patch
|
blob
|
history
diff --git
a/arch/powerpc/sysdev/xics/icp-hv.c
b/arch/powerpc/sysdev/xics/icp-hv.c
index
ad81171
..
21b9d1b
100644
(file)
--- a/
arch/powerpc/sysdev/xics/icp-hv.c
+++ b/
arch/powerpc/sysdev/xics/icp-hv.c
@@
-174,6
+174,7
@@
int icp_hv_init(void)
icp_ops = &icp_hv_ops;
+ of_node_put(np);
return 0;
}