MLK-13798: rtc: snvs: add a missing write sync
authorGuy Shapiro <guy.shapiro@mobi-wize.com>
Sun, 29 Jan 2017 09:57:19 +0000 (11:57 +0200)
committerNitin Garg <nitin.garg@nxp.com>
Mon, 19 Mar 2018 20:21:46 +0000 (15:21 -0500)
The clear of the LPTA_EN flag should be synced before writing to the
alarm register. Omitting this synchronization creates a race when
trying to change existing alarm.

(cherry picked from commit 7bb633b1a9812a6b9f3e49d0cf17f60a633914e5)

Signed-off-by: Guy Shapiro <guy.shapiro@mobi-wize.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Tested-by: Leonard Crestez <leonard.crestez@nxp.com>
Reviewed-by: Octavian Purdila <octavian.purdila@nxp.com>
drivers/rtc/rtc-snvs.c

index e636493..2b086be 100644 (file)
@@ -193,6 +193,7 @@ static int snvs_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
        rtc_tm_to_time(alrm_tm, &time);
 
        regmap_update_bits(data->regmap, data->offset + SNVS_LPCR, SNVS_LPCR_LPTA_EN, 0);
+       rtc_write_sync_lp(data);
        regmap_write(data->regmap, data->offset + SNVS_LPTAR, time);
 
        /* Clear alarm interrupt status bit */